tuhaihe commented on PR #1188: URL: https://github.com/apache/cloudberry/pull/1188#issuecomment-3034353479
> > What's the team's preference on backward compatibility vs. clean removal for this change? > > The reason why we do this is as the quicklz has license argument, so it's better to remove all of the codes which have `quicklz` key words. As we have changed some files such as CI related files in our repo, it can't cherry-pick from gp upstream directly, this approach may be better. For migration, we need time to discuss how to achieve it, but maybe we should remove quicklz firstly to avoid the danger of unnecessary license argument. Hi @zhangwenchao-123, in my opinion, including the keyword `quicklz` in the source code is okay. Also, some files related to the old CI have been removed from the Cloudberry repo, which doesn't prevent us from cherry-picking the relevant commits from GP to Cloudberry. I think we should adopt the GP approach and cherry-pick the relevant commits to Cloudberry. (If that's not enough, we need to improve based on these commits.) This also helps keep the GP method at its best for traditional GP users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
