robertmu commented on PR #6: URL: https://github.com/apache/cloudberry-go-libs/pull/6#issuecomment-3067133808
> Hi @robertmu, thank you for your PR. Please **rebase** the code rather than merge code. Linear commit history is recommend to make tracking changes easier. The previous commit 3c26b84 incorrectly removed support for Greenplum versions prior to GPDB 6. However, due to customer needs, our tool must now be fully compatible with all versions supported by gpbackup. If I were to fix this by rebasing my branch, commit 3c26b84 would be dropped from the commit history. This altered history would prevent me from pushing my changes back to the repository. Therefore, I propose that we first revert the problematic commit. After that is done, I may proceed with the rebase safely -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
