tuhaihe commented on PR #1226:
URL: https://github.com/apache/cloudberry/pull/1226#issuecomment-3076523760
Hi @ZTE-EBASE, here is some feedback on your commit message:
To be updated:
- Title: We need to use `Apache Cloudberry` or `Cloudberry` instead of
`Cloudberry Database`
- Commit body, we should refactor it based on the original commit messages,
not just combine them simply. If there is a need, we can list the key changes
one by one to have a better visual.
- Commit trailer: I believe you commit on behalf of your organization, so
you can list your organization's public contact information (Org name + Org
public contact point); also, we can add the related mailing thread or GitHub
Discussion URL for a better context.
Here is one sample based one your commit message for your reference:
```
Feature: Add SFTP support to gpfdist for data ingestion
gpfdist, Cloudberry's parallel file distribution program,
traditionally required data files to be co-located with the gpfdist
process. This limitation made it cumbersome to load data from remote
servers, often requiring an extra data transfer step.
This commit extends gpfdist to support the SFTP protocol, enabling
users to ingest data directly from remote servers. This enhancement
streamlines ETL workflows by allowing `CREATE EXTERNAL TABLE` to specify
SFTP locations.
Key changes include:
- Integrating the libssh2 library to handle SFTP communication.
- Implementing remote file reading capabilities within gpfdist.
- Adding the `LIBSSH2` preprocessor macro to conditionally compile the
new SFTP-related code.
Authored-by: Your NAME <[email protected]>
Co-authored-by: More NAME <[email protected]>
on-behalf-of: @ZTE-EBASE <[email protected]>
See: https://github.com/apache/cloudberry/discussions/1205
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
