This is an automated email from the ASF dual-hosted git repository. maxyang pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry-go-libs.git
commit 0359a65821e217d82bd933936820c1bef88b6084 Author: moonsn <[email protected]> AuthorDate: Wed Apr 19 16:50:25 2023 +0800 Format string after judge level in pglog This commit change the behavior of the gplog package when record debug and verbose level logs. When the log level set to "Info", a "Debug" or "Verbose" function call should do less job. The old code will a format for the log message before judge the log level, buf if the log level is "Info", the format call is an redundant operation. So, we change it to judge the log level before format the format operation. --- gplog/gplog.go | 42 ++++++++++++++++++++++++------------------ 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/gplog/gplog.go b/gplog/gplog.go index 1dbec86..ea7735b 100644 --- a/gplog/gplog.go +++ b/gplog/gplog.go @@ -232,12 +232,14 @@ func SetErrorCode(code int) { func Info(s string, v ...interface{}) { logMutex.Lock() defer logMutex.Unlock() - message := GetLogPrefix("INFO") + fmt.Sprintf(s, v...) - if logger.fileVerbosity >= LOGINFO { - _ = logger.logFile.Output(1, message) - } - if logger.shellVerbosity >= LOGINFO { - _ = logger.logStdout.Output(1, message) + if logger.fileVerbosity >= LOGINFO || logger.shellVerbosity >= LOGINFO { + message := GetLogPrefix("INFO") + fmt.Sprintf(s, v...) + if logger.fileVerbosity >= LOGINFO { + _ = logger.logFile.Output(1, message) + } + if logger.shellVerbosity >= LOGINFO { + _ = logger.logStdout.Output(1, message) + } } } @@ -252,24 +254,28 @@ func Warn(s string, v ...interface{}) { func Verbose(s string, v ...interface{}) { logMutex.Lock() defer logMutex.Unlock() - message := GetLogPrefix("DEBUG") + fmt.Sprintf(s, v...) - if logger.fileVerbosity >= LOGVERBOSE { - _ = logger.logFile.Output(1, message) - } - if logger.shellVerbosity >= LOGVERBOSE { - _ = logger.logStdout.Output(1, message) + if logger.fileVerbosity >= LOGVERBOSE || logger.shellVerbosity >= LOGVERBOSE { + message := GetLogPrefix("DEBUG") + fmt.Sprintf(s, v...) + if logger.fileVerbosity >= LOGVERBOSE { + _ = logger.logFile.Output(1, message) + } + if logger.shellVerbosity >= LOGVERBOSE { + _ = logger.logStdout.Output(1, message) + } } } func Debug(s string, v ...interface{}) { logMutex.Lock() defer logMutex.Unlock() - message := GetLogPrefix("DEBUG") + fmt.Sprintf(s, v...) - if logger.fileVerbosity >= LOGDEBUG { - _ = logger.logFile.Output(1, message) - } - if logger.shellVerbosity >= LOGDEBUG { - _ = logger.logStdout.Output(1, message) + if logger.fileVerbosity >= LOGDEBUG || logger.shellVerbosity >= LOGDEBUG { + message := GetLogPrefix("DEBUG") + fmt.Sprintf(s, v...) + if logger.fileVerbosity >= LOGDEBUG { + _ = logger.logFile.Output(1, message) + } + if logger.shellVerbosity >= LOGDEBUG { + _ = logger.logStdout.Output(1, message) + } } } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
