robertmu commented on code in PR #13:
URL:
https://github.com/apache/cloudberry-gpbackup/pull/13#discussion_r2227736045
##########
backup/backup.go:
##########
@@ -11,10 +11,10 @@ import (
"sync"
"time"
- "github.com/greenplum-db/gp-common-go-libs/cluster"
- "github.com/greenplum-db/gp-common-go-libs/dbconn"
- "github.com/greenplum-db/gp-common-go-libs/gplog"
- "github.com/greenplum-db/gp-common-go-libs/operating"
+ "github.com/cloudberrydb/gp-common-go-libs/cluster"
Review Comment:
Thank you for your review and the great suggestion.
I completely agree that the import paths should ultimately be updated to
`github.com/apache/cloudberry-go-libs`. That is the correct long-term goal, and
I appreciate you pointing it out.
The immediate reason for keeping the current paths in this PR is a technical
requirement of the Go Modules system. The dependency we are currently pointing
to (`github.com/cloudberrydb/gp-common-go-libs`) explicitly declares its
canonical module path in its `go.mod` file like this:
```go
module github.com/cloudberrydb/gp-common-go-libs
```
According to Go's module mechanics, all `import` statements within our
project **must** match this declared module path for the compiler to resolve
the packages correctly.
I plan to handle the migration to the `apache/cloudberry-go-libs` path
**once** the `apache:sync-with-upstream` branch is ready to officially switch
its base dependency. That way, we can coordinate the changes in both projects
at the same time.
With that in mind, would it be acceptable to keep the current
`github.com/cloudberrydb/...` paths for this PR to proceed?
Thanks again for your sharp eye and valuable feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
