tuhaihe commented on code in PR #1256:
URL: https://github.com/apache/cloudberry/pull/1256#discussion_r2238156540


##########
gpMgmt/bin/Makefile:
##########
@@ -79,26 +79,41 @@ endif
 #
 # Python Libraries
 #
+# Download Python source packages using pip3 download
+# This replaces the previously bundled tar.gz files to comply with Apache 
Release policy
+#
+MOCK_VERSION=1.0.1
+PYGRESQL_VERSION=5.2
+PSUTIL_VERSION=5.7.0
+PYYAML_VERSION=5.4.1
+
+download-python-deps:
+       @echo "--- Downloading Python dependencies for gpMgmt modules"
+       @mkdir -p $(PYLIB_SRC_EXT)

Review Comment:
   Good catch! But I prefer to make minimal changes to the code logic. Not too 
many tweaks here.
   
   We might remove the `${SRC}/ext` directory in a future PR if it's no longer 
used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to