robertmu opened a new pull request, #14:
URL: https://github.com/apache/cloudberry-gpbackup/pull/14
Following the introduction of database type detection (GPDB vs. CBDB) in the
underlying common library, this commit applies that new capability throughout
the gpbackup codebase.
Previously, all version-based feature checks implicitly assumed the target
database was Greenplum. This was insufficient and could lead to incorrect
behavior when running against Apache Cloudberry Database, as features might be
enabled or disabled based on a versioning scheme that doesn't apply.
This change systematically updates version-sensitive conditional logic to be
database-aware. It uses the new `IsGPDB()` and `IsCBDB()` helpers to create
compound checks.
For example, logic previously guarded by `version.AtLeast("7")` is now
updated to `(version.IsGPDB() && version.AtLeast("7")) || version.IsCBDB()`.
This correctly scopes features to specific GPDB versions while enabling them by
default for Cloudberry where appropriate.
This is a critical step to ensure that gpbackup functions reliably and
generates correct backup files for both Greenplum and Cloudberry environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
