my-ship-it commented on code in PR #1310:
URL: https://github.com/apache/cloudberry/pull/1310#discussion_r2281614113
##########
src/backend/gporca/libgpopt/src/xforms/CDecorrelator.cpp:
##########
@@ -426,7 +426,14 @@ CDecorrelator::FProcessGbAgg(CMemoryPool *mp, CExpression
*pexpr,
return false;
}
- // TODO: 12/20/2012 - ; check for strictness of agg function
+ if (0 == popAggOriginal->Pdrgpcr()->Size())
+ {
+ CColRef *pcrCount = nullptr;
+ if (CUtils::FHasCountAgg((*pexpr)[1], &pcrCount))
Review Comment:
It's OK to process count star and count any here. But it's a general
problem, namely, any AggFunc with not nulll initval we should process here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
