gfphoenix78 commented on code in PR #20:
URL:
https://github.com/apache/cloudberry-gpbackup/pull/20#discussion_r2303329378
##########
integration/metadata_globals_queries_test.go:
##########
@@ -344,6 +344,16 @@ CREATEEXTTABLE (protocol='gphdfs', type='writable')`
for _, role := range results {
if role.Name == "role1" {
+ if connectionPool.Version.IsCBDB() {
+ // Cloudberry uses
SCRAM-SHA-256 by default, while the test was
+ // written expecting an MD5
hash. The exact SCRAM hash is
+ // unpredictable due to
salting, so we only check its prefix.
+
Expect(role.Password).To(HavePrefix("SCRAM-SHA-256$"))
Review Comment:
Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]