gfphoenix78 commented on code in PR #29:
URL:
https://github.com/apache/cloudberry-gpbackup/pull/29#discussion_r2307300092
##########
integration/predata_functions_queries_test.go:
##########
@@ -827,7 +827,16 @@ LANGUAGE SQL`)
}
testhelper.AssertQueryRuns(connectionPool,
fmt.Sprintf("CREATE LANGUAGE %su", plpythonString))
- defer testhelper.AssertQueryRuns(connectionPool,
fmt.Sprintf("DROP LANGUAGE %su", plpythonString))
+
+ // In Cloudberry (PG14+), a direct `CREATE LANGUAGE`
command for a language
+ // like plpython3u implicitly links it to its
corresponding extension, making
+ // it a core extension member. Therefore, it must be
cleaned up by dropping
+ // the extension, not the language.
+ if connectionPool.Version.IsCBDB() {
+ defer
testhelper.AssertQueryRuns(connectionPool, fmt.Sprintf("DROP EXTENSION IF
EXISTS %su CASCADE", plpythonString))
Review Comment:
I remember that the GPDB also supports `DROP EXTENSION plpython` to drop the
language.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
