HuSen8891 commented on code in PR #1338:
URL: https://github.com/apache/cloudberry/pull/1338#discussion_r2317613636
##########
src/backend/utils/sort/tuplesort.c:
##########
@@ -3232,6 +3232,14 @@ dumptuples(Tuplesortstate *state, bool alltuples)
!alltuples)
return;
+ /*
+ * do nothing if we are told to finish execution.
+ */
+ if (QueryFinishPending)
Review Comment:
> which caller reset tuplecontext ?
In dumptuples, the tuplecontext is reset when all memtuples are consumed or
QueryFinishPending is set to true.
##########
src/backend/utils/sort/tuplesort.c:
##########
@@ -3232,6 +3232,14 @@ dumptuples(Tuplesortstate *state, bool alltuples)
!alltuples)
return;
+ /*
+ * do nothing if we are told to finish execution.
+ */
+ if (QueryFinishPending)
Review Comment:
In dumptuples, the tuplecontext is reset when all memtuples are consumed or
QueryFinishPending is set to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
