gongxun0928 commented on code in PR #1324:
URL: https://github.com/apache/cloudberry/pull/1324#discussion_r2336274557
##########
contrib/pax_storage/src/cpp/access/pax_scanner.cc:
##########
@@ -326,8 +326,8 @@ void PaxScanDesc::EndScan() {
}
TableScanDesc PaxScanDesc::BeginScanExtractColumns(
- Relation rel, Snapshot snapshot, int /*nkeys*/,
- struct ScanKeyData * /*key*/, ParallelTableScanDesc parallel_scan,
+ Relation rel, Snapshot snapshot, int nkeys,
+ struct ScanKeyData *key, ParallelTableScanDesc parallel_scan,
Review Comment:
It is best to keep the function signature consistent with it in the table
access method
```
/*
* GPDB: Extract columns for scan from targetlist and quals. This is
mainly
* for AOCS tables.
*/
TableScanDesc (*scan_begin_extractcolumns) (Relation rel,
Snapshot snapshot,
int nkeys, struct ScanKeyData *key,
ParallelTableScanDesc parallel_scan,
struct PlanState *ps,
uint32 flags);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
