gfphoenix78 commented on code in PR #1388:
URL: https://github.com/apache/cloudberry/pull/1388#discussion_r2431850857
##########
gpcontrib/gp_exttable_fdw/extaccess.c:
##########
@@ -491,6 +491,24 @@ external_getnext_init(PlanState *state)
return desc;
}
+static void
+check_error(FileScanDesc scan)
+{
+ char *relname = RelationGetRelationName(scan->fs_rd);
+ int ebuflen = 512;
+ char ebuf[512] = {'\0'};
+
+ /* current only CFTYPE_EXEC will read stderr to ebuf */
+ url_ferror(scan->fs_file, -1, ebuf, ebuflen);
Review Comment:
Why is the returned value ignored? The existing code checks the returned
value first, then the error buffer.
The `ebuf` could only initialize to an empty cstring, not necessarily all
bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
