gongxun0928 commented on code in PR #1333:
URL: https://github.com/apache/cloudberry/pull/1333#discussion_r2439049581
##########
contrib/pax_storage/src/cpp/storage/filter/pax_row_filter.cc:
##########
@@ -45,19 +46,54 @@ static inline void FindAttrsInQual(Node *qual, bool *proj,
int ncol,
}
static bool BuildExecutionFilterForColumns(Relation rel, PlanState *ps,
- pax::ExecutionFilterContext *ctx) {
+ pax::ExecutionFilterContext *ctx,
+ ScanKey key, int nkeys) {
List *qual = ps->plan->qual;
List **qual_list;
ListCell *lc;
bool *proj;
int *qual_atts;
int natts = RelationGetNumberOfAttributes(rel);
- if (!qual || !IsA(qual, List)) return false;
+ int ret = false;
+
+ if (key && nkeys > 0) {
+ if (nodeTag(ps) != T_SeqScanState) {
Review Comment:
We don't need to support DynamicSeqScanState here. Even if the plan uses
DynamicSeqScanNode for partitioned tables, it's always a regular SeqScan on a
single table. So this will always be a SeqScanState.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
