my-ship-it commented on code in PR #1375:
URL: https://github.com/apache/cloudberry/pull/1375#discussion_r2431786910
##########
src/include/cdb/cdbconn.h:
##########
@@ -37,24 +37,25 @@ typedef struct SegmentDatabaseDescriptor
*/
int32 segindex;
- /*
+ /*
* A non-NULL value points to the PGconn block of a successfully
* established connection to the segment database.
*/
PGconn *conn;
- /*
- * Connection info saved at most recent PQconnectdb.
- *
- * NB: Use malloc/free, not palloc/pfree, for the items below.
- */
- uint32 motionListener; /* interconnect listener
port */
- int32 backendPid;
- char *whoami; /* QE identifier for msgs */
- bool isWriter;
- int identifier;
/* unique identifier in the cdbcomponent segment pool */
- double establishConnTime; /* the time
of establish connection to the segment,
-
* -1 means this connection is cached */
+ /*
+ * Connection info saved at most recent PQconnectdb.
+ *
+ * NB: Use malloc/free, not palloc/pfree, for the items below.
+ */
+ uint32 motionListener; /* interconnect listener port */
Review Comment:
So do we need to keep the original format consistent with the rest of the
structure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
