avamingli commented on code in PR #1381:
URL: https://github.com/apache/cloudberry/pull/1381#discussion_r2415614355
##########
src/backend/foreign/foreign.c:
##########
@@ -419,9 +419,6 @@ GetForeignTableOnSegment(Oid relid)
SysScanDesc ftscan;
HeapTuple fttuple;
int i;
- int segNumber;
-
- segNumber = GetForeignTableSegNumbers(relid);
Review Comment:
The codes are introduced by CBDB at commit
ed64982034245e8b46926b75f349a4a5d5b8fd67,
It looks like the intent to update ForeignTable.num_segments was missed or
forgotten in this block, specifically around line 440. Instead of deleting the
logic, we should ensure ForeignTable.num_segments is assigned the correct value
there.
cc @oppenheimer01
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
