yjhjstz commented on code in PR #1409:
URL: https://github.com/apache/cloudberry/pull/1409#discussion_r2449111609
##########
src/backend/gpopt/translate/CTranslatorRelcacheToDXL.cpp:
##########
@@ -862,13 +862,30 @@
CTranslatorRelcacheToDXL::RetrieveRelDistributionOpFamilies(CMemoryPool *mp,
void
CTranslatorRelcacheToDXL::AddSystemColumns(CMemoryPool *mp,
CMDColumnArray *mdcol_array,
-
Relation /*rel*/)
+
Relation rel)
{
+ // Get storage type to determine which system columns are supported
+ IMDRelation::Erelstoragetype rel_storage_type =
RetrieveRelStorageType(rel);
+ BOOL is_standalone_ao_table = ((rel_storage_type ==
IMDRelation::ErelstorageAppendOnlyRows ||
+ rel_storage_type ==
IMDRelation::ErelstorageAppendOnlyCols)) &&
+ rel->rd_rel->relkind !=
RELKIND_PARTITIONED_TABLE &&
+ !rel->rd_rel->relispartition;
Review Comment:
not support, add check ErelstoragePAX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
