This is an automated email from the ASF dual-hosted git repository.
reshke pushed a commit to branch cbdb-postgres-merge
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
The following commit(s) were added to refs/heads/cbdb-postgres-merge by this
push:
new 6759bf7b322 Remove heap_fetch_extended function.
6759bf7b322 is described below
commit 6759bf7b3222c2f946d9472aa83f5c66e35495ee
Author: reshke <[email protected]>
AuthorDate: Sun Dec 14 18:49:48 2025 +0000
Remove heap_fetch_extended function.
Sync src/backend/access/heap/heapam.c internals with upstream.
heap_fetch_extended introudced
https://github.com/postgres/postgres/commit/c590e514a90ddc9237a3438efb05be074d43452b
as back-paches fix from HEAD. There is no point to keep this function
after postgresql-16 merge
---
src/backend/access/heap/heapam.c | 19 -------------------
src/include/access/heapam.h | 3 ---
2 files changed, 22 deletions(-)
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index 90380d52eac..3e7fa5fd19e 100644
--- a/src/backend/access/heap/heapam.c
+++ b/src/backend/access/heap/heapam.c
@@ -1424,25 +1424,6 @@ heap_fetch(Relation relation,
HeapTuple tuple,
Buffer *userbuf,
bool keep_buf)
-{
- return heap_fetch_extended(relation, snapshot, tuple, userbuf, false);
-}
-
-/*
- * heap_fetch_extended - fetch tuple even if it fails snapshot
test
- *
- * If keep_buf is true, then upon finding a tuple that is valid but fails
- * the snapshot check, we return the tuple pointer in tuple->t_data and the
- * buffer ID in *userbuf, keeping the buffer pin, just as if it had passed
- * the snapshot. (The function result is still "false" though.)
- * If keep_buf is false then this behaves identically to heap_fetch().
- */
-bool
-heap_fetch_extended(Relation relation,
- Snapshot snapshot,
- HeapTuple tuple,
- Buffer *userbuf,
- bool keep_buf)
{
ItemPointer tid = &(tuple->t_self);
ItemId lp;
diff --git a/src/include/access/heapam.h b/src/include/access/heapam.h
index 16d298fd21c..a1ef3e50c4e 100644
--- a/src/include/access/heapam.h
+++ b/src/include/access/heapam.h
@@ -229,9 +229,6 @@ extern bool heap_getnextslot_tidrange(TableScanDesc sscan,
extern uint32 heap_scan_flags(Relation relation);
extern bool heap_fetch(Relation relation, Snapshot snapshot,
HeapTuple tuple, Buffer *userbuf,
bool keep_buf);
-extern bool heap_fetch_extended(Relation relation, Snapshot snapshot,
- HeapTuple
tuple, Buffer *userbuf,
- bool keep_buf);
extern bool heap_hot_search_buffer(ItemPointer tid, Relation relation,
Buffer
buffer, Snapshot snapshot, HeapTuple heapTuple,
bool
*all_dead, bool first_call);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
