tuhaihe commented on PR #1483: URL: https://github.com/apache/cloudberry/pull/1483#issuecomment-3685538612
More comments: 1. License Compliance The `contrib/aifun/requirements.txt` file introduces new Python dependencies, but cannot be added the standard Apache license header. So need to add it to `pom.xml` for license compliance checking exclusion. 2. Build Integration I noticed that `aifun` is not added to `contrib/Makefile`'s SUBDIRS list. Should this extension be built automatically with Cloudberry, or is it expected to be built separately by users who need it? Personally, I would prefer the former, as it helps make the new extension more visible and easier for users to discover. BTW, the current Makefile runs `pip install` during `make install`, which auto-pulls Python dependencies and requires network access. This could be problematic for production/offline builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
