reshke commented on code in PR #1505:
URL: https://github.com/apache/cloudberry/pull/1505#discussion_r2646492756


##########
src/bin/pg_dump/pg_backup_archiver.c:
##########
@@ -4935,43 +4935,8 @@ CloneArchive(ArchiveHandle *AH)
 
        /* re-establish fixed state */
        if (AH->mode == archModeRead)
-       {

Review Comment:
   Thats because of 
[56b46d3](https://github.com/postgres/postgres/commit/56b46d3), basically. 
Changes of this commit are half-made in cloudberry. This code is creating 
connection both before and after `if (AH->mode == archModeRead)` statement (on 
line 4934 and if each of if-else branch). This causes an error of assertion 
failure in pg_dump parallel run (pg_dump -j$num, see examples in TAP test for 
exact command). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to