Copilot commented on code in PR #1512:
URL: https://github.com/apache/cloudberry/pull/1512#discussion_r2649201878
##########
src/backend/gporca/libgpopt/src/operators/CPhysicalDynamicTableScan.cpp:
##########
@@ -91,4 +91,19 @@ CPhysicalDynamicTableScan::PppsDerive(CMemoryPool *mp,
return pps;
}
+
+CEnfdProp::EPropEnforcingType
+CPhysicalDynamicTableScan::EpetRewindability(CExpressionHandle &exprhdl,
+ const
CEnfdRewindability *per) const
Review Comment:
The indentation of the second parameter is excessive and inconsistent with
common C++ style. The parameter should align with the opening parenthesis or be
indented by a standard amount (e.g., one tab or 4 spaces).
```suggestion
const CEnfdRewindability *per) const
```
##########
src/backend/gporca/libgpopt/include/gpopt/operators/CPhysicalDynamicTableScan.h:
##########
@@ -74,6 +74,12 @@ class CPhysicalDynamicTableScan : public CPhysicalDynamicScan
CPartitionPropagationSpec *PppsDerive(
CMemoryPool *mp, CExpressionHandle &exprhdl) const override;
+ // return rewindability property enforcing type for this operator
+ CEnfdProp::EPropEnforcingType EpetRewindability(
+ CExpressionHandle &, // exprhdl
+ const CEnfdRewindability * // per
+ ) const override;
Review Comment:
The parameter alignment is inconsistent with the implementation. The second
parameter should be indented to align with the first parameter or follow a
consistent indentation pattern.
```suggestion
CEnfdProp::EPropEnforcingType EpetRewindability(CExpressionHandle &,
const CEnfdRewindability *) const override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
