Mulily0513 commented on code in PR #22:
URL: https://github.com/apache/cloudberry-pxf/pull/22#discussion_r2652659347
##########
automation/sqlrepo/features/gpupgrade/extension2_1/step_1_before_running_pxf_pre_gpupgrade/expected/query01.ans:
##########
@@ -40,13 +40,13 @@ FROM pg_catalog.pg_extension AS e
INNER JOIN pg_catalog.pg_proc AS p ON (p.oid = d.objid)
WHERE d.deptype = 'e' AND e.extname = 'pxf'
ORDER BY 1;
- proname | prosrc | probin
----------------------+------------------------------+-------------
- pxf_read | pxfprotocol_import | $libdir/pxf
- pxf_validate | pxfprotocol_validate_urls | $libdir/pxf
- pxf_write | pxfprotocol_export | $libdir/pxf
- pxfdelimited_import | pxfdelimited_import | $libdir/pxf
- pxfwritable_export | gpdbwritableformatter_export | $libdir/pxf
- pxfwritable_import | gpdbwritableformatter_import | $libdir/pxf
+ proname | prosrc | probin
+---------------------+------------------------------+----------------------------------
+ pxf_read | pxfprotocol_import | $PXF_HOME/gpextable/pxf
Review Comment:
Because in our packaged install the PXF extension library is shipped under
${PXF_HOME}/gpextable (and pxf.control module_pathname is rewritten
accordingly), not in GPDB $libdir. So the expected output needs to match that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
