reshke commented on code in PR #1534:
URL: https://github.com/apache/cloudberry/pull/1534#discussion_r2699637344
##########
src/backend/storage/smgr/smgr.c:
##########
@@ -492,9 +493,11 @@ smgrcreate(SMgrRelation reln, ForkNumber forknum, bool
isRedo)
* already because we are in a WAL replay sequence.
*/
void
-smgrcreate_ao(RelFileNodeBackend rnode, int32 segmentFileNum, bool isRedo)
+smgrcreate_ao(const struct f_smgr_ao *smgr,
+ RelFileNodeBackend rnode,
+ int32 segmentFileNum, bool isRedo)
{
- mdcreate_ao(rnode, segmentFileNum, isRedo);
+ smgr->smgr_create_ao(rnode, segmentFileNum, isRedo);
Review Comment:
actually, I would say that `smgr == null or smgr->smgr_create_ao = null` is
condition that should lead to ereport(ERROR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
