avamingli commented on PR #1525: URL: https://github.com/apache/cloudberry/pull/1525#issuecomment-3782560006
> Therefore, before moving forward, I recommend we validate this change with a TPCDS 1T benchmark (using AOCO tables). If no plan changes are observed, I have no objection. If we can identify a better-performing setting through such testing, that would be even more valuable. Based on my manual review of all 99 TPC-DS queries, I have confirmed that **Query 72 contains the highest number of explicit JOINs: 11 tables with 10 JOIN operations**, which is below the value modified in your PR. Therefore, this change should theoretically have no impact on query planning for explicit joins. Regarding queries with a higher number of table references, such as **Query 64, which lists over 18 tables in its FROM clause**, these are presented as a `FROM-LIST` and are governed by the `from_collapse_limit` GUC. Consequently, your change will not affect them either. This change looks good to me, thanks, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
