my-ship-it commented on code in PR #1520:
URL: https://github.com/apache/cloudberry/pull/1520#discussion_r2719886815
##########
contrib/udp2/ic_udp2.c:
##########
@@ -179,7 +179,7 @@ SetupInterconnectUDP2(EState *estate)
Gp_interconnect_queue_depth == 4 &&
Gp_interconnect_snd_queue_depth == 2)
{
- int32 perQueue = Gp_interconnect_mem_size /
+ int32 perQueue = ((int64)Gp_interconnect_mem_size * 1024 *
1024) /
Review Comment:
How about we change the variable name? This name is easily confused with
Gp_max_packet_size, but the units are different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
