reshke opened a new pull request, #1548:
URL: https://github.com/apache/cloudberry/pull/1548
I was casually compiling Cloudberry with some postrgesql extensions and
faced a compile issue:
```
/usr/local/cbdb/include/postgresql/server/utils/elog.h:215:13: error:
conflicting declaration of C function ‘void errmsg_internal(const char*, ...)’
215 | extern void errmsg_internal(const char *fmt,...)
pg_attribute_printf(1, 2);
| ^~~~~~~~~~~~~~~
```
This is basically because contents of
https://github.com/postgres/postgres/commit/bda6dedbea599209048bc51115ecb2062ceb976c
is missing in cbdb. So, lets cherry-pick it
original commit msg follows;
====
This reverts the parts of commit 17a28b03645e27d73bf69a95d7569b61e58f06eb
that changed ereport's auxiliary functions from returning dummy integer values
to returning void. It turns out that a minority of compilers complain (not
entirely unreasonably) about constructs such as
(condition) ? errdetail(...) : 0
if errdetail() returns void rather than int. We could update those call
sites to say "(void) 0" perhaps, but the expectation for this patch set was
that ereport callers would not have to change anything. And this aspect of the
patch set was already the most invasive and least compelling part of it, so
let's just drop it.
Per buildfarm.
Discussion:
https://postgr.es/m/ca+fd4k6n8ejnvzpm8nme+y+05mz-sm8z_bgkixzka34r+ej...@mail.gmail.com
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
