This is an automated email from the ASF dual-hosted git repository.
chenjinbao1989 pushed a commit to branch cbdb-postgres-merge
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
The following commit(s) were added to refs/heads/cbdb-postgres-merge by this
push:
new fc950191322 Disable re-run for PgBaseBackup
fc950191322 is described below
commit fc9501913221b351f55a32f4d48568e773708789
Author: Jinbao Chen <[email protected]>
AuthorDate: Wed Feb 4 09:23:59 2026 +0800
Disable re-run for PgBaseBackup
---
gpMgmt/sbin/gpsegrecovery.py | 40 ++++++++++++++++++++--------------------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/gpMgmt/sbin/gpsegrecovery.py b/gpMgmt/sbin/gpsegrecovery.py
index 811a73ccbb5..ef1bc88738f 100644
--- a/gpMgmt/sbin/gpsegrecovery.py
+++ b/gpMgmt/sbin/gpsegrecovery.py
@@ -39,26 +39,26 @@ class FullRecovery(Command):
target_gp_dbid=self.recovery_info.target_segment_dbid,
progress_file=self.recovery_info.progress_file)
self.logger.info("Running pg_basebackup with progress output
temporarily in %s" % self.recovery_info.progress_file)
- try:
- cmd.run(validateAfter=True)
- except Exception as e: #TODO should this be ExecutionError?
- self.logger.info("Running pg_basebackup failed: {}".format(str(e)))
-
- # If the cluster never has mirrors, cmd will fail
- # quickly because the internal slot doesn't exist.
- # Re-run with `create_slot`.
- # GPDB_12_MERGE_FIXME could we check it before? or let
- # pg_basebackup create slot if not exists.
- cmd = PgBaseBackup(self.recovery_info.target_datadir,
- self.recovery_info.source_hostname,
- str(self.recovery_info.source_port),
- create_slot=True,
- replication_slot_name=self.replicationSlotName,
- forceoverwrite=True,
-
target_gp_dbid=self.recovery_info.target_segment_dbid,
- progress_file=self.recovery_info.progress_file)
- self.logger.info("Re-running pg_basebackup, creating the slot this
time")
- cmd.run(validateAfter=True)
+ # try:
+ cmd.run(validateAfter=True)
+ # except Exception as e: #TODO should this be ExecutionError?
+ # self.logger.info("Running pg_basebackup failed:
{}".format(str(e)))
+ #
+ # # If the cluster never has mirrors, cmd will fail
+ # # quickly because the internal slot doesn't exist.
+ # # Re-run with `create_slot`.
+ # # GPDB_12_MERGE_FIXME could we check it before? or let
+ # # pg_basebackup create slot if not exists.
+ # cmd = PgBaseBackup(self.recovery_info.target_datadir,
+ # self.recovery_info.source_hostname,
+ # str(self.recovery_info.source_port),
+ # create_slot=True,
+ #
replication_slot_name=self.replicationSlotName,
+ # forceoverwrite=True,
+ #
target_gp_dbid=self.recovery_info.target_segment_dbid,
+ #
progress_file=self.recovery_info.progress_file)
+ # self.logger.info("Re-running pg_basebackup, creating the slot
this time")
+ # cmd.run(validateAfter=True)
self.error_type = RecoveryErrorType.DEFAULT_ERROR
self.logger.info("Successfully ran pg_basebackup for dbid: {}".format(
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
