ostinru commented on code in PR #80: URL: https://github.com/apache/cloudberry-pxf/pull/80#discussion_r2939702241
########## ci/docker/pxf-cbdb-dev/ubuntu/script/build_pxf.sh: ########## @@ -9,7 +9,22 @@ source /usr/local/cloudberry-db/cloudberry-env.sh export PATH=$GPHOME/bin:$PATH sudo apt update -sudo apt install -y openjdk-11-jdk maven +sudo apt install -y openjdk-11-jdk maven curl unzip coreutils + +# Install Gradle (we do not vendor gradle-wrapper.jar in the source tree) Review Comment: It's really unusual to use system-wide gradle. As I can see: * apache/kafka keeps `gradlew` in source tree. * apache/calcite keeps `gradlew` in source tree and remove from source bundles: https://issues.apache.org/jira/browse/CALCITE-4575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
