tuhaihe commented on PR #81: URL: https://github.com/apache/cloudberry-pxf/pull/81#issuecomment-4072018803
Cool! Thanks @ostinru for your great work! I know this PR is still in the draft, just a reminder in case we're missing, FYI: - Maybe we can add the `.github/workflows/gradle-wrapper-validation.yml` - Remove the file `server/gradle/wrapper/gradle-wrapper.jar` from the source code - Can add a note in the `README.md`, like: > PXF does not vendor `gradle-wrapper.jar` in the source tree. When running `make`, you will download it from its official site. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
