tuhaihe commented on code in PR #1651: URL: https://github.com/apache/cloudberry/pull/1651#discussion_r3015668674
########## configure: ########## @@ -24833,11 +24834,4 @@ fi # The configure args contain '-Wl,-rpath,\$$ORIGIN`, when it falls # as a C literal string, it's invalid, so converting `\` to `\\` # to be correct for C program. -case $build_os in -darwin*) - sed -i '' '/define CONFIGURE_ARGS/s,\([^\\]\)\\\$\$,\1\\\\$$,g' src/include/pg_config.h - ;; -*) - sed -i '/define CONFIGURE_ARGS/s,\([^\\]\)\\\$\$,\1\\\\$$,g' src/include/pg_config.h Review Comment: @zhangyue1818 Hi, could you take a look at this? The best way is to define in configure.ac, then regenerate configure, not edit it directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
