my-ship-it commented on code in PR #1661: URL: https://github.com/apache/cloudberry/pull/1661#discussion_r3031410866
########## configure.ac: ########## @@ -3204,4 +3204,11 @@ AC_OUTPUT # The configure args contain '-Wl,-rpath,\$$ORIGIN`, when it falls # as a C literal string, it's invalid, so converting `\` to `\\` # to be correct for C program. -sed -i '/define CONFIGURE_ARGS/s,\([[^\\]]\)\\\$\$,\1\\\\$$,g' src/include/pg_config.h +case $build_os in Review Comment: Typical practice in this project is to commit configure.ac and configure together. Since commit 7e867f6 already patched configure directly, this isn't broken today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
