avamingli opened a new pull request, #1666:
URL: https://github.com/apache/cloudberry/pull/1666
Fix issue #1665
The commit df1e2ff ("Prevent CREATE TABLE from using dangling tablespace")
added a call to TablespaceLockTuple() inside TablespaceCreateDbspace() for
every non-default tablespace, including the common path where the per-database
directory already exists. That lock acquisition calls LockSharedObject(),
which calls AcceptInvalidationMessages(), allowing pending sinval messages to
be processed at an unexpected point deep inside smgrcreate().
This creates a crash window during VACUUM of a heap table (including
auxiliary tables such as the aoseg table of an AO relation) that lives in a
non-default tablespace and has never been vacuumed before (so no FSM or VM fork
exists yet):
lazy_scan_heap
-> visibilitymap_pin -> vm_readbuf -> vm_extend
smgrcreate(VM fork) + CacheInvalidateSmgr() <- queues
SHAREDINVALSMGR_ID
-> RecordPageWithFreeSpace -> fsm_readbuf -> fsm_extend
smgrcreate(FSM fork) -> mdcreate
-> TablespaceCreateDbspace [CBDB-specific for non-default tablespaces]
-> TablespaceLockTuple -> LockSharedObject
-> AcceptInvalidationMessages()
-> smgrclosenode() -> rel->rd_smgr = NULL
rel->rd_smgr->smgr_cached_nblocks[FSM_FORKNUM] = ...
-> SIGSEGV (NULL dereference) at freespace.c:637
Fix: add RelationOpenSmgr(rel) after smgrcreate() in both fsm_extend()
(freespace.c) and vm_extend() (visibilitymap.c). RelationOpenSmgr is a no-op
when rd_smgr is still valid, and re-opens the smgr handle if the sinval handler
has closed it. The identical guard already exists earlier in both functions
for the LockRelationForExtension path.
Add a regression test (vacuum_fsm_nondefault_tablespace) covering both a
plain heap table and an AO table in a non-default tablespace.
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
