woblerr commented on code in PR #84:
URL: https://github.com/apache/cloudberry-backup/pull/84#discussion_r3056165501
##########
.github/workflows/cloudberry-backup-ci.yml:
##########
@@ -316,6 +316,25 @@ jobs:
set +e
case "${TEST_TARGET}" in
+ smoke)
Review Comment:
It looks like, if any of the `--version` or `--help` commands fail, the
shell just keeps going and happily prints "All smoke tests passed".
In line 317 there is `set +x`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
