ostinru commented on code in PR #108:
URL: https://github.com/apache/cloudberry-pxf/pull/108#discussion_r3108802193
##########
server/Makefile:
##########
@@ -109,7 +109,7 @@ install-jdbc-drivers: stage-jdbc-drivers
echo "ERROR: PXF_HOME is not set"; exit 2; \
fi
mkdir -p "$(PXF_HOME)"/lib
- rm -f "$(PXF_HOME)"/lib/clickhouse-jdbc-*.jar
+ rm -f "$(PXF_HOME)"/lib/*.jar
Review Comment:
Originally, I have added this line due to the problems with local build &
test: multiple versions of clickhouse-jdbc JAR were installed. And test results
was incorrect.
I think that I can remove this line completely. We shouldn't remove files
from user's folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
