MisterRaindrop commented on code in PR #17:
URL: https://github.com/apache/cloudberry-go-libs/pull/17#discussion_r3138392303
##########
dbconn/dbconn.go:
##########
@@ -20,7 +20,7 @@ import (
* but it had a bug with the way it handled certain encodings.
* pgx seems to handle these encodings properly.
*/
- _ "github.com/jackc/pgx/v4/stdlib"
+ _ "github.com/jackc/pgx/v5/stdlib"
Review Comment:
Heads up — dbconn/dbconn.go:215 still passes statement_cache_capacity=0. In
v4 that just disabled the cache; in v5 it leaves
statementCache nil while DefaultQueryExecMode is still
QueryExecModeCacheStatement, so every parameterized query will blow up at
runtime with:
cannot use QueryExecModeCacheStatement with disabled statement cache
Easy fix: swap statement_cache_capacity=0 for default_query_exec_mode=exec
(and tweak the nearby pgx/v4 comment). Tests won't catch
this since they use go-sqlmock — worth a quick smoke test against a real
GPDB before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
