Vlasdislav commented on code in PR #1894:
URL: https://github.com/apache/cloudberry/pull/1894#discussion_r3795213344


##########
contrib/pax_storage/sql/pax_inject_fault.sql:
##########
@@ -1,17 +1,23 @@
+-- ignore non-determenistic warnings, hints, details
+-- start_matchignore
+-- m/^WARNING:\s+/
+-- m/^HINT:\s+/
+-- m/^DETAIL:\s+/
+-- end_matchignore
 create table t_insert(a int);
 select gp_inject_fault_infinite('fts_probe','skip',dbid) FROM 
gp_segment_configuration WHERE role = 'p' AND content = -1;
 select gp_request_fts_probe_scan();
 select gp_inject_fault('orc_writer_write_tuple','panic',dbid) FROM 
gp_segment_configuration WHERE role = 'p' AND content > -1;
 -- failed because of fault injection
+-- start_ignore
 insert into t_insert select generate_series(1,10);
-
+-- end_ignore
 -- start_ignore

Review Comment:
   Would you like to combine two consecutive ignore blocks?



##########
contrib/pax_storage/expected/pax_inject_fault.out:
##########
@@ -26,8 +26,9 @@ HINT:  Inject an infinite 'skip' into the 'fts_probe' fault 
to disable FTS probi
 (3 rows)
 
 -- failed because of fault injection
+-- start_ignore
 insert into t_insert select generate_series(1,10);
-ERROR:  fault triggered, fault name:'orc_writer_write_tuple' fault type:'panic'
+-- end_ignore
 -- start_ignore

Review Comment:
   Would you like to combine two consecutive ignore blocks?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to