tuhaihe opened a new pull request, #1912:
URL: https://github.com/apache/cloudberry/pull/1912
The REL_16 (PG16) merge added an upstream PostgreSQL --with-zstd block on
top of the existing Greenplum one, leaving two PGAC_ARG_BOOL(with, zstd, ...)
declarations in configure.ac.
The two AC_ARG_WITH expansions interact through ${with_zstd+set}: the first
block (default "no") sets with_zstd, so the second block (default "yes") sees
it already set and becomes a no-op. The effective default therefore flipped
from "yes" to "no", so a plain ./configure disabled zstd and gpcontrib/zstd no
longer built by default -- a regression from REL_2_STABLE.
Drop the upstream default-"no" declaration and keep the single Greenplum
block (default "yes"), moving the -I/-D/-L flag injection into it so the later
AC_CHECK_LIB/AC_CHECK_HEADER probes still resolve zstd in non-standard
prefixes. This mirrors the parallel --with-lz4 block. The generated configure
is updated to match.
Assisted-by: Claude Code
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
