ZTE-EBASE opened a new pull request, #1930: URL: https://github.com/apache/cloudberry/pull/1930
what: In the `putIntoUnackQueueRing` function, for flow control methods other than `INTERCONNECT_FC_METHOD_LOSS_ADVANCE`, the corresponding timer wheel interval is `TIMER_SPAN`. When calculating the packet's index within the timer wheel, `TIMER_SPAN` is used; however, when calculating the current timer wheel position to check against, `TIMER_SPAN_LOSS` is used instead. This creates a logical inconsistency between the two calculations. why: This is a logical contradiction: the same timer wheel should rely on a consistent interval constant for both indexing incoming packets and determining the current wheel position. Using `TIMER_SPAN` in one place and `TIMER_SPAN_LOSS` in the other deviates from the intended design. Although no issues have been observed in actual testing, the inconsistency is a latent defect that could cause incorrect wheel-position matching under certain timing conditions. How： Unify the constant used for the current timer wheel position calculation to be consistent with the packet-index calculation. Specifically: Change the "current check" calculation from `TIMER_SPAN_LOSS` to `TIMER_SPAN` so both sides use the same interval. <!-- Thank you for your contribution to Apache Cloudberry (Incubating)! --> Fixes #ISSUE_Number ### What does this PR do? <!-- Brief overview of the changes, including any major features or fixes --> ### Type of Change - [ ] Bug fix (non-breaking change) - [ ] New feature (non-breaking change) - [ ] Breaking change (fix or feature with breaking changes) - [ ] Documentation update ### Breaking Changes <!-- Remove if not applicable. If yes, explain impact and migration path --> ### Test Plan <!-- How did you test these changes? --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Passed `make installcheck` - [ ] Passed `make -C src/test installcheck-cbdb-parallel` ### Impact <!-- Remove sections that don't apply --> **Performance:** <!-- Any performance implications? --> **User-facing changes:** <!-- Any changes visible to users? --> **Dependencies:** <!-- New dependencies or version changes? --> ### Checklist - [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code) - [ ] Added/updated documentation - [ ] Reviewed code for security implications - [ ] This PR contains AI-assisted code generation - [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers) ### Additional Context <!-- Any other information that would help reviewers? Remove if none --> ### CI Skip Instructions <!-- To skip CI builds, add the appropriate CI skip identifier to your PR title. The identifier must: - Be in square brackets [] - Include the word "ci" and either "skip" or "no" - Only use for documentation-only changes or when absolutely necessary --> --- <!-- Join our community: - Mailing list: [[email protected]](https://lists.apache.org/[email protected]) (subscribe: [email protected]) - Discussions: https://github.com/apache/cloudberry/discussions --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
