harikrishna-patnala commented on a change in pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#discussion_r572139690
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
##########
@@ -433,6 +437,10 @@ public Long getStoragePolicy() {
return storagePolicy;
}
+ public Boolean getDynamicScalingEnabled() {
+ return isDynamicScalingEnabled == null ? Boolean.TRUE :
isDynamicScalingEnabled;
Review comment:
1. parameter on template registration is purely a property of a template
which defines whether template has hypervisor supported tools installed or not.
It is not an option. So default is assumed to be "false". If tools are
installed on template then admin will mark it explicitly to "true".
2. default value of global setting is also set to "false" assuming admin
will enable the feature if they want overall on CloudStack management zones.
3. When coming to VM or Service offering, these are options to enable or
disable at VM level. Given a template is dynamically scalable and global
setting is set to true, User can still have option to decide whether he/she
wants the VM to dynamically scalable or not. Defaulted to "true" because by if
no option is given when deploying the VM then it adheres the template property
and global setting by admin. If we default it to "false" and User did not set
any option then even though the template is dynamically scalable and global
setting is "true", VM cannot scale.
In summary VM can be scalable only when all options are true. Any parameter
setting to "false" will make the VM not dynamically scalable. Each parameter
acts as kill switch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
