DaanHoogland commented on a change in pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#discussion_r579080201
##########
File path:
plugins/outofbandmanagement-drivers/ipmitool/src/main/java/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolOutOfBandManagementDriver.java
##########
@@ -37,6 +37,7 @@
import java.util.List;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
+import org.apache.commons.lang3.StringUtils;
Review comment:
that is a lazy exaggeration, we have a facade for string utils and we
are hampered by several 3rd party libraries for which we don't. If there are
resources for making such a thing for spring, great. Let's do it.
BTW, in this case I didn't :-1: on this issue, but on other counts I might
as well. duckduck "using 3rd party library facades", will give you some wisdom
on this.
out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
