sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580213756
##########
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -417,6 +425,40 @@ private String composeThumbnailUrl(String rootUrl,
VirtualMachine vm, HostVO hos
return sb.toString();
}
+ /**
+ * Sets the URL to establish a VNC over websocket connection
+ */
+ private void setWebsocketUrl(VirtualMachine vm, ConsoleProxyClientParam
param) {
+ String ticket = acquireVncTicketForVmwareVm(vm);
Review comment:
_ acquireVncTicketForVmwareVm()_ returns null, in case of any
errors/exceptions, check for the same ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
