DaanHoogland commented on a change in pull request #4707:
URL: https://github.com/apache/cloudstack/pull/4707#discussion_r582684759
##########
File path: server/src/main/java/org/apache/cloudstack/ha/HAManagerImpl.java
##########
@@ -156,19 +156,16 @@ public boolean transitionHAState(final HAConfig.Event
event, final HAConfig haCo
if (result) {
final String message = String.format("Transitioned host HA
state from:%s to:%s due to event:%s for the host id:%d",
currentHAState, nextState, event,
haConfig.getResourceId());
- if (LOG.isTraceEnabled()) {
- LOG.trace(message);
- }
+ LOG.debug(message);
Review comment:
log4j 3 has my vote, big job though. this is a pattern that finds
following and this is what i want to prevent, we need very elaborate Sting
construction at times. I wouldn't hassle about info or above, but debug and
trace, yes. (also aggree on readible code btw, but isEnabled is very explicit.
And also agree on your use of `format()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
