Spaceman1984 commented on pull request #4717: URL: https://github.com/apache/cloudstack/pull/4717#issuecomment-790390637
> Consider if you can reuse existing isrecursive/domainid handler code (see service layer that handles listVolumes, listVMs... etc). @rhtyd the _accountMgr.buildACLViewSearchBuilder(sb, domainId, isRecursive, permittedAccounts, listProjectResourcesCriteria); method is not compatible with how the records are fetched in the listUsageRecords class. In getUsageRecords() in the UsageServiceImpl class file the result set is built using `SearchCriteria<UsageVO> sc = _usageDao.createSearchCriteria();` , we don't have a SearchBuilder object to pass to the method. The code is not reusable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
