harikrishna-patnala commented on a change in pull request #4805:
URL: https://github.com/apache/cloudstack/pull/4805#discussion_r594046340
##########
File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
##########
@@ -757,6 +757,15 @@ public PrimaryDataStoreInfo
createPool(CreateStoragePoolCmd cmd) throws Resource
throw new CloudRuntimeException("Failed to add data store: " +
e.getMessage(), e);
}
+ // create entry for storage pool capacity
Review comment:
May I know if this specific to any storage type ?
Because I already see the same code creating capacity entries for cluster
scoped storage pool and local storage pools.
cluster storage :
https://github.com/apache/cloudstack/blob/75fb1d91eee6e18b2247d39ea4a3cfda04101c07/engine/storage/src/main/java/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java#L159
Local storage :
https://github.com/apache/cloudstack/blob/75fb1d91eee6e18b2247d39ea4a3cfda04101c07/engine/storage/src/main/java/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java#L152
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
