shwstppr commented on a change in pull request #4816:
URL: https://github.com/apache/cloudstack/pull/4816#discussion_r594555739
##########
File path:
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java
##########
@@ -44,4 +46,12 @@ public static String getPVbootloaderArgs(String guestOS) {
}
return "";
}
+
+ public static String getSRNameLabel(final StorageFilerTO primaryStore) {
+ if (Storage.StoragePoolType.PreSetup.equals(primaryStore.getType()) &&
+ !primaryStore.getPath().contains(primaryStore.getUuid())) {
+ return primaryStore.getPath().replace("/", "");
Review comment:
https://github.com/apache/cloudstack/blob/4.15/plugins/storage/volume/default/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java#L340-L342
Primary store setup code uses the same. I can change this though.
For pre-setup SR path is `/SR_NAME_LABEL` so it might not be as dangerous as
it looks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
