sureshanaparti commented on a change in pull request #4826:
URL: https://github.com/apache/cloudstack/pull/4826#discussion_r595734259
##########
File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
##########
@@ -460,50 +463,37 @@ public Answer sendToPool(StoragePool pool, Command cmd)
throws StorageUnavailabl
return answers[0];
}
- private GetStorageStatsAnswer getStoragePoolStats(StoragePool pool,
GetStorageStatsCommand cmd) {
- DataStoreProvider storeProvider =
_dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
- DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
+ private GetStorageStatsAnswer getStoragePoolStats(StoragePool pool,
GetStorageStatsCommand cmd, DataStoreDriver storeDriver) {
Review comment:
```suggestion
private GetStorageStatsAnswer getStoragePoolStats(StoragePool pool,
GetStorageStatsCommand cmd) {
```
@slavkap can you pick `storeDriver` from the pool itself, instead of
explicitly pass as argument here.
```
DataStoreProvider storeProvider =
_dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName());
DataStoreDriver storeDriver = storeProvider.getDataStoreDriver();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
