sureshanaparti commented on a change in pull request #4378:
URL: https://github.com/apache/cloudstack/pull/4378#discussion_r595754539
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVMCmd.java
##########
@@ -169,9 +165,9 @@ public void execute() {
try {
VirtualMachine migratedVm = null;
- if (getHostId() != null) {
+ if (getStoragePoolId() == null) {
Review comment:
@ustcweizhou whenever host / storage pool is not specified in the cmd,
instead of directly picking a suitable dest host to migrate to, I think it is
better to confirm it (from the user) through a API cmd param (something like
_chooseHost_ / _selectHost_). If user is not OK to auto select host, then
throw appropriate message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
