sureshanaparti commented on a change in pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#discussion_r596645655
########## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVMCmd.java ########## @@ -169,9 +165,9 @@ public void execute() { try { VirtualMachine migratedVm = null; - if (getHostId() != null) { + if (getStoragePoolId() == null) { Review comment: @weizhouapache host id in the cmd is UUID, so i think it is better to take input from another param when host id is null. If host id is not null, ignore auto selection. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org