[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4748: Template cleanup : Update vm_template table to set template as removed on deletion

[GitBox]

Pearl1594 commented on a change in pull request #4748:
URL: https://github.com/apache/cloudstack/pull/4748#discussion_r597404882



##########
File path: 
engine/schema/src/main/java/com/cloud/storage/dao/VMTemplateDaoImpl.java
##########
@@ -430,6 +431,11 @@ public boolean configure(String name, Map<String, Object> 
params) throws Configu
         ParentTemplateIdSearch.and("state", 
ParentTemplateIdSearch.entity().getState(), SearchCriteria.Op.EQ);
         ParentTemplateIdSearch.done();
 
+        InactiveUnremovedTmpltSearch = createSearchBuilder();
+        InactiveUnremovedTmpltSearch.and("state", 
InactiveUnremovedTmpltSearch.entity().getState(), SearchCriteria.Op.IN);
+        InactiveUnremovedTmpltSearch.and("removed", 
InactiveUnremovedTmpltSearch.entity().getRemoved(), SearchCriteria.Op.NULL);
+        InactiveUnremovedTmpltSearch.done();

Review comment:
       Thanks @DaanHoogland . It was supposed to be referenced at 
listUnRemovedTemplatesByStates() - fixed it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org