nvazquez commented on a change in pull request #4829:
URL: https://github.com/apache/cloudstack/pull/4829#discussion_r598676065
##########
File path: ui/public/locales/en.json
##########
@@ -1986,6 +1987,7 @@
"label.start.rolling.maintenance": "Start Rolling Maintenance",
"label.start.rolling.maintenance.payload": "Payload",
"label.start.vlan": "Start VLAN",
+"label.start.vm": "Start VM",
Review comment:
May not be needed, can we use the existing 'label.action.start.instance'
instead?
##########
File path: ui/public/locales/en.json
##########
@@ -1807,6 +1807,7 @@
"label.rolename": "Role",
"label.roles": "Roles",
"label.roletype": "Role Type",
+"label.rootdisksize": "Root disk size (GB)",
Review comment:
Also may not be needed, can we use 'label.root.disk.size' instead? Is
this one being used?
##########
File path: ui/src/views/compute/DeployVM.vue
##########
@@ -543,6 +545,9 @@
:options="keyboardSelectOptions"
></a-select>
</a-form-item>
+ <a-form-item :label="$t('label.start.vm')">
Review comment:
As above: what about 'label.action.start.instance' here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
